fix Container.clipBehaviour, clips the shadow in decoration#64362
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This PR is missing a test. Can you please add one to show what this is fixing and to ensure that we never break it again? Thanks. |
|
@goderbauer I added a golden test. here is the snapshot:
@Piinks I don't have access to the Flutter Gold dashboard. not sure how to submit this snapshot. |
|
Hey @sahandevs I can help you check in the images. Can you update this to fix the analyzer? |
|
Gold has detected about 1 untriaged digest(s) on patchset 5. |
|
Gold has detected about 1 untriaged digest(s) on patchset 6. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Co-authored-by: Kate Lovett <katelovett@google.com>
|
Gold has detected about 1 untriaged digest(s) on patchset 7. |
|
Golden file changes are available for triage from new commit, Click here to view. |
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution!
Description
fix Container.clipBehaviour, clips the shadow in BoxDecoration if provided.
fixed by changing the clip order
Related Issues
Tests
I added the following tests:
Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.