Reland "Prevent material switch from recreating its render object when it becomes disabled (#61398)"#64354
Merged
LongCatIsLooong merged 1 commit intoflutter:masterfrom Aug 21, 2020
Conversation
…n it becomes disabled (flutter#61398)", reverted in flutter#64062 This reverts commit 90908b0.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
The google testing failures are caused by not including the base commit (the revert). Since the reverted PR already landed in dev, I'll ignore those failures and merge this PR. |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…n it becomes disabled (flutter#61398)", reverted in flutter#64062 (flutter#64354)
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…n it becomes disabled (flutter#61398)", reverted in flutter#64062 (flutter#64354)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 90908b0 (#64062).
Description
See #64058 for a benchmark results comparison.
Relalted Issues
#64058 & #64332
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.