Add rect logic to getOffsetToReveal when onlySlivers is true #64295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80c7038 to
51ddf6f
Compare
1971333 to
7a9d640
Compare
goderbauer
approved these changes
Aug 24, 2020
| // `rect` in the new intermediate coordinate system. | ||
| Rect rectLocal; | ||
| // Our new reference frame render object's main axis extent. | ||
| double localMaxExtent; |
Member
There was a problem hiding this comment.
should this be called mainExtend instead of max? (not sure what max is referring too....)
4 tasks
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we disregard
rectingetOffsetToReveal'sleadingScrollOffsetcalculation whenonlySliversis true. This PR adds the missing logic in that branch. This is needed to reland #56413, as persistent headers will have their ownshowOnScreenoverrides once that PR relands.Also moved some code from #56413 into this PR.
Related Issues
#25507
Tests
Improved existing tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.