Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 5, 2020

Description

The flutter version reports has been ignore the stable versions ("x.y.z") when determine the current version on a commit after x.y.z. This PR un-ignores it.
Also, we currently returns a version like x.y.{z+1}.pre.$commits if the last tag is a stable version. To match the other pre release version syntax, this PR also fix it with x.y.{z+1}-0.0.pre.$commits

Related Issues

Fixes #62994

Tests

I've updated the existing tests to match the new behavior

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 5, 2020
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020

Not sure how we can test if the correct version is picked up if the last tag is a stable version.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit c9cd825 into flutter:master Aug 5, 2020
@cyanglaz cyanglaz deleted the pre_version branch August 5, 2020 22:20
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_tools] Version calculation wrong if last tag is stable

2 participants