Skip to content

[hotfix] flutter create -t plugin remove no-op iOS folder and set sdk min to 1.20.0 #62939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cyanglaz wants to merge 3 commits into from
Closed

[hotfix] flutter create -t plugin remove no-op iOS folder and set sdk min to 1.20.0 #62939

cyanglaz wants to merge 3 commits into from

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 5, 2020

This is a cherry-pick of 004f90f and 2459f5c

Fixes #60215

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 5, 2020 03:20
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 5, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

1 similar comment
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 5, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot requested a review from jmagman as a code owner August 5, 2020 03:20
@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 5, 2020
@cyanglaz cyanglaz changed the base branch from master to flutter-1.20-candidate.7 August 5, 2020 03:20
@cyanglaz cyanglaz mentioned this pull request Aug 5, 2020
Closed
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020 •
edited
Loading

@pcsosinski @csells This is the hotfix PR.
When the new hotfix branch is created, I'll update the target branch.

Edit:
No need to update the target branch.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020

I think we should cherry-pick #62630 in as well, which adds more tests. So we can be more confident. @jmagman @pcsosinski WDYT?

@cyanglaz cyanglaz force-pushed the 1_21_remove_ios_folder branch from f728d5b to 863efe8 Compare August 5, 2020 16:33
christopherfujino
christopherfujino approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit about removing a TODO comment.

packages/flutter_tools/test/commands.shard/permeable/create_test.dart Outdated
expect(projectDir.childDirectory('windows').existsSync(), false);
expect(projectDir.childDirectory('macos').existsSync(), false);

// TODO(cyanglaz): no-op iOS folder should be removed after 1.20.0 release
Copy link
Contributor

@christopherfujino christopherfujino Aug 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove TODO?

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020

Experienced some issue with tags. Closing this in favor of #62990

@cyanglaz cyanglaz closed this Aug 5, 2020
@cyanglaz cyanglaz mentioned this pull request Aug 5, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter create -t plugin should not create no-op iOS folders in 1.20.0 stable release

2 participants

@cyanglaz @christopherfujino