Skip to content

Add integration test for plugins without ios directories #62630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Aug 3, 2020
Merged

Add integration test for plugins without ios directories #62630

jmagman merged 2 commits into from
Aug 3, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 31, 2020

Description

Integration test to create an Android-only plugin with no ios directory, then add that dependency to another plugin. Make sure the other plugin can build for iOS, and doesn't embed the Android-only plugin.

Related Issues

#61561
I locally verified this integration test passes on top of #62372

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behavior with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See [Test Coverage].

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 31, 2020
@jmagman jmagman requested a review from cyanglaz July 31, 2020 00:35
@jmagman jmagman self-assigned this Jul 31, 2020
@jmagman jmagman force-pushed the plugin-ios-integration branch from bb0f75a to 1c06f1b Compare July 31, 2020 00:37
cyanglaz
cyanglaz approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Jul 31, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite web_tests-3-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman merged commit 1513b97 into flutter:master Aug 3, 2020
@jmagman jmagman deleted the plugin-ios-integration branch August 3, 2020 17:24
@cyanglaz cyanglaz mentioned this pull request Aug 5, 2020
Closed
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@jmagman @Pragya007
Add integration test for plugins without ios directories (flutter#62630)
2c0c9c1
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Add integration test for plugins without ios directories (flutter#62630)
7bda108
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmagman @fluttergithubbot @cyanglaz @googlebot