Skip to content

Conversation

@CareF
Copy link
Contributor

@CareF CareF commented Aug 5, 2020

Description

This PR is needed when flutter/engine#20229 is merged into the engine.

Related Issues

#62689

Tests

This PR updates 'Flutter.Frame event fired' test in packages/flutter/test/scheduler/scheduler_test.dart

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@CareF CareF requested a review from liyuqian August 5, 2020 01:32
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 5, 2020
@CareF CareF marked this pull request as draft August 5, 2020 01:32
@CareF CareF marked this pull request as ready for review August 8, 2020 23:26
@CareF
Copy link
Contributor Author

CareF commented Aug 8, 2020

@liyuqian Now we can start the process to remove the duplicate constructor.

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit fb54465 into flutter:master Aug 10, 2020
@CareF CareF deleted the rolling_frame_timing branch August 10, 2020 17:59
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants