Layout paragraph using the appropriate width based on its textWidthBasis#62657
Merged
LongCatIsLooong merged 1 commit intoflutter:masterfrom Aug 4, 2020
Merged
Conversation
justinmc
approved these changes
Jul 31, 2020
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks, I probably created this bug when I introduced TextWidthBasis.
| newWidth = _applyFloatingPointHack(_paragraph.longestLine); | ||
| break; | ||
| case TextWidthBasis.parent: | ||
| newWidth = maxIntrinsicWidth; |
Contributor
There was a problem hiding this comment.
Does this need to be clamped like it was before?
Contributor
Author
There was a problem hiding this comment.
it gets clamped after the switch.
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a
TextPainter.textWidthBasisislongestLine, theTextPaintershould layout its paraph using the width of its longest line from the 1st layout pass.Related Issues
Fixes #62550
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.