-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fixes physics not working when StepperType.horizontal is selected #62635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes physics not working when StepperType.horizontal is selected #62635
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 similar comment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Hey @HansMuller ! Sorry for the ping but I saw you self-requested a review. This is my first PR and I haven't got any reply in 13 days. Perhaps something is wrong with the PR? Thank you very much! |
|
Sorry about the delay. This seems like a reasonable change, however you'll need to add a simple test that verifies that the Stepper's ListView has the expected scroll physics in this case. Should be pretty easy to check the Stepper's ListView descendant in a test. The new test just cover both the vertical and horizontal cases. |
|
Hey @HansMuller ! Sorry for the delay (and somehow closing the PR). Hopefully, that test looks good to you. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've restarted some of the tests, since the failed for internal reasons. Will land this when the tree is green. Thanks for the contribution!
|
I'm afraid that it will be necessary to sync up with the master and push a new commit to get this PR past the failing tests. I submitted #64208 because sorting that much out isn't as straightforward as it should be. |
|
Hey @HansMuller ! Could you please tell me how to do that? Last time I tried syncing stuff, I deleted all my changes and somehow closed this PR. Sorry, this whole git thing still confuses me |
|
You can do this Or if you know that the flutter/flutter remote is in, say |
Description
Stepper's physics property is not set when StepperType.horizontal is selected. This PR adds the physics property.
Related Issues
Fixes [#34174]
Tests
Added a new test to check if physics is working for vertical and horizontal stepper.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.