Skip to content

Conversation

@thecalamiity
Copy link
Contributor

@thecalamiity thecalamiity commented Jul 31, 2020

Description

Stepper's physics property is not set when StepperType.horizontal is selected. This PR adds the physics property.

Related Issues

Fixes [#34174]

Tests

Added a new test to check if physics is working for vertical and horizontal stepper.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 31, 2020
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

1 similar comment
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@thecalamiity
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@HansMuller HansMuller self-requested a review August 6, 2020 23:44
@thecalamiity
Copy link
Contributor Author

Hey @HansMuller ! Sorry for the ping but I saw you self-requested a review. This is my first PR and I haven't got any reply in 13 days. Perhaps something is wrong with the PR? Thank you very much!

@HansMuller
Copy link
Contributor

Sorry about the delay. This seems like a reasonable change, however you'll need to add a simple test that verifies that the Stepper's ListView has the expected scroll physics in this case. Should be pretty easy to check the Stepper's ListView descendant in a test. The new test just cover both the vertical and horizontal cases.

@thecalamiity thecalamiity reopened this Aug 19, 2020
@thecalamiity
Copy link
Contributor Author

thecalamiity commented Aug 19, 2020

Hey @HansMuller ! Sorry for the delay (and somehow closing the PR). Hopefully, that test looks good to you.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I've restarted some of the tests, since the failed for internal reasons. Will land this when the tree is green. Thanks for the contribution!

@HansMuller
Copy link
Contributor

I'm afraid that it will be necessary to sync up with the master and push a new commit to get this PR past the failing tests.

I submitted #64208 because sorting that much out isn't as straightforward as it should be.

@thecalamiity
Copy link
Contributor Author

thecalamiity commented Aug 20, 2020

Hey @HansMuller ! Could you please tell me how to do that? Last time I tried syncing stuff, I deleted all my changes and somehow closed this PR. Sorry, this whole git thing still confuses me

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Aug 20, 2020

You can do this

git checkout master
git pull
git checkout stepper-physics-issue
git merge master
git push

Or if you know that the flutter/flutter remote is in, say upstream, you can do

# When you're on stepper-physics-issue
git fetch upstream
git merge upstream/master
git push

@fluttergithubbot fluttergithubbot merged commit a1097d7 into flutter:master Aug 20, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants