Continue the clipBehavior breaking change #61366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
There are some failed tests in the test run of cl/321021912. Investigating... |
Contributor
Author
|
This is currently blocked by dnfield/flutter_svg#384. The "customer: dream" needs it to update the code so we can continue this breaking change. CC @dnfield |
This follows flutter#59364 and cl/319911104
Contributor
Author
|
Several CLs that "Add clipBehavior to FittedBox, Wrap, and Stack" have landed internally and I'm starting a new test at cl/331657143. I'm only expecting minor AA mismatches in this test. If it's as expected, I'll merge this PR. CC @renyou |
New FittedBox are added to Google very quickly. Let's first roll other part of changes into Google first.
hpoul
added a commit
to authpass/flutter_speed_dial
that referenced
this pull request
Sep 16, 2020
irasekh3
added a commit
to irasekh3/flutter_speed_dial
that referenced
this pull request
Sep 16, 2020
…lutter/flutter#61366. This PR removes the `overflow` parameter when setting up the `Stack` object which is used as part of the flutter speed dial object and therefore is breaking build targeting the master branch of flutter
irasekh3
added a commit
to irasekh3/flutter_speed_dial
that referenced
this pull request
Sep 17, 2020
It seems as though as a result of flutter/flutter@7948a78#diff-7f71460835520a1820d69cd0b6994c01L3316 which was merged into flutter master in flutter/flutter#61366 The Stack object removed the option for overflow and instead clipBehavior should be set to Clip.none
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Sep 26, 2020
This is a continuation of flutter#61366 after cl/333620714 See also https://flutter.dev/go/clip-behavior
liyuqian
added a commit
that referenced
this pull request
Sep 29, 2020
This is a continuation of #61366 after cl/333620714 See also https://flutter.dev/go/clip-behavior
romanlytvyn
added a commit
to romanlytvyn/flutter-slide-to-act
that referenced
this pull request
Sep 30, 2020
Fix the breaking change introduced by flutter/flutter@7948a78 and merged into flutter master by flutter/flutter#61366 by replacing `overflow: Overflow.visible,` with `clipBehavior: Clip.none,` in the Stack object instantiation.
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #59364 and cl/319911104