Skip to content

Check for Xcode 11 and Xcode 12 directory names in build_ios_framework_module_test #60045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Jun 23, 2020
Merged

Check for Xcode 11 and Xcode 12 directory names in build_ios_framework_module_test #60045

jmagman merged 1 commit into from
Jun 23, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jun 23, 2020

Description

Xcode 12 changed a generated XCFramework directory from ios-armv7_arm64->ios-arm64_armv7. Check for the existence of both instead of an explicit Xcode version check.

Related Issues

Fixes #60043.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically labels Jun 23, 2020
@jmagman jmagman self-assigned this Jun 23, 2020
christopherfujino
christopherfujino approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@christopherfujino
Copy link
Contributor

christopherfujino commented Jun 23, 2020

So Xcode's change won't break anything in the tool?

@jmagman
Copy link
Member Author

jmagman commented Jun 23, 2020 •
edited
Loading

So Xcode's change won't break anything in the tool?

No, the tool doesn't care about this structure, it calls xcodebuild to generate the XCFramework, and then Xcode consumes them in an add-to-app host app. The test is just checking that the files actually get produced.
https://flutter.dev/docs/development/add-to-app/ios/project-setup#option-b---embed-frameworks-in-xcode

@jmagman jmagman merged commit 8b79bb9 into flutter:master Jun 23, 2020
@jmagman jmagman deleted the xcf-dirname branch June 23, 2020 21:36
@flutter-github-sync
Copy link

flutter-github-sync commented Jun 24, 2020

Google testing passed!

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Check for Xcode 11 and Xcode 12 directory names in build_ios_framewor…
7258d66 
…k_module_test (flutter#60045)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build_ios_framework_module_test fails with Xcode 12

4 participants

@jmagman @christopherfujino @flutter-github-sync @googlebot