Skip to content

Revert "Characters Package" #59677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renyou merged 1 commit into from
Jun 17, 2020
Merged

Revert "Characters Package" #59677

renyou merged 1 commit into from
Jun 17, 2020

Conversation

@renyou
Copy link
Contributor

@renyou renyou commented Jun 17, 2020

This PR breaks Google internal tests.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 17, 2020
@HansMuller HansMuller self-requested a review June 17, 2020 15:19
justinmc
justinmc approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, will we need to revert #59267 as well? That PR is actually the one that introduced the characters package, but it didn't start being used until the one reverted by this (#53381).

@justinmc justinmc mentioned this pull request Jun 17, 2020
Closed
@renyou renyou merged commit a99d146 into master Jun 17, 2020
@renyou renyou deleted the revert-53381-characters branch June 17, 2020 15:39
@justinmc
Copy link
Contributor

justinmc commented Jun 17, 2020

Making a note that I found no problem with #59267, so I won't revert it for now.

justinmc added a commit to justinmc/flutter that referenced this pull request Jun 18, 2020
@justinmc
Revert "Revert "Characters Package (flutter#53381)" (flutter#59677)"
2ae6fff 
This reverts commit a99d146.
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@renyou @zljj0818
Revert "Characters Package (flutter#53381)" (flutter#59677)
f5862b9 
This reverts commit e0ed12c.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@renyou @mingwandroid
Revert "Characters Package (flutter#53381)" (flutter#59677)
58c0faf 
This reverts commit e0ed12c.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@justinmc justinmc justinmc approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renyou @justinmc @googlebot @fluttergithubbot