Skip to content

Revert "Add clipBehavior to widgets with clipRect" #58344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mehmetf merged 1 commit into from
May 31, 2020
Merged

Revert "Add clipBehavior to widgets with clipRect" #58344

mehmetf merged 1 commit into from
May 31, 2020

Conversation

@mehmetf
Copy link
Contributor

@mehmetf mehmetf commented May 31, 2020

Reverts #55977

Non trivial breakages in g3.

@fluttergithubbot fluttergithubbot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels May 31, 2020
@mehmetf mehmetf requested a review from Hixie May 31, 2020 03:59
@mehmetf mehmetf mentioned this pull request May 31, 2020
Closed
9 tasks
@mehmetf mehmetf requested a review from jonahwilliams May 31, 2020 04:26
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 31, 2020

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@mehmetf mehmetf merged commit 1d395c5 into master May 31, 2020
@mehmetf mehmetf deleted the revert-55977-clip branch May 31, 2020 14:41
@goderbauer
Copy link
Member

goderbauer commented Jun 1, 2020

LGTM

/cc @liyuqian FYI

@iskakaushik
Copy link
Contributor

iskakaushik commented Jun 1, 2020

This change also causes some breakages in the Fuchsia roll. @liyuqian is it possible to structure this as a soft-transition?

cc: @chaselatta

@liyuqian
Copy link
Contributor

liyuqian commented Jun 1, 2020

It should be possible to have a soft-transition. The old PR was supposed to be non-breaking but clearly I missed something. Can you please attach the failed log here so I can make sure that my next try won't fail on the same test?

@mehmetf
Copy link
Contributor Author

mehmetf commented Jun 1, 2020

I highly recommend that the revert of this revert be staged to g3 and tested before being merged.

@liyuqian please reach out to @renyou in internal chat to figure out how. We have tools for that kind of thing now :-).

@iskakaushik
Copy link
Contributor

iskakaushik commented Jun 1, 2020

This is the failure log on the Fuchsia side: http://shortn/_Gy8PvjWzQG

@chaselatta
Copy link
Contributor

chaselatta commented Jun 1, 2020

The failure on our end came from overflow being removed from the Stack widget and being replaced with clipBehavior. We would need overflow to remain until we can migrate our usage to clipBehavior

liyuqian added a commit to liyuqian/flutter that referenced this pull request Jun 17, 2020
@liyuqian
Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977
5b25a08 
)" (flutter#58344)"

This reverts commit 1d395c5.
liyuqian added a commit that referenced this pull request Jun 17, 2020
@liyuqian
Reland non-breaking "Add clipBehavior to widgets with clipRect #55977" (
42e02d6 
#59364)

* Revert "Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)"

This reverts commit 1d395c5.

* Add missed Overflow
zljj0818 pushed a commit to zljj0818/flutter that referenced this pull request Jun 22, 2020
@liyuqian @zljj0818
Reland non-breaking "Add clipBehavior to widgets with clipRect flutte…
06833ea 
…r#55977" (flutter#59364)

* Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)"

This reverts commit 1d395c5.

* Add missed Overflow
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@liyuqian @mingwandroid
Reland non-breaking "Add clipBehavior to widgets with clipRect flutte…
9f27130 
…r#55977" (flutter#59364)

* Revert "Revert "Add clipBehavior to widgets with clipRect (flutter#55977)" (flutter#58344)"

This reverts commit 1d395c5.

* Add missed Overflow
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Awaiting requested review from Hixie

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mehmetf @fluttergithubbot @goderbauer @iskakaushik @liyuqian @chaselatta @googlebot