Switch to CMake for Linux desktop #57238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've never used CMake before, so it's probably not perfect. I'm pretty sure it's better than the Makefile was though :) |
jonahwilliams
approved these changes
May 14, 2020
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Changes to tests, comments, formatting generally LGTM
I trust your judgement on the cmake
Also, how dare you leave a trailing space!
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
May 16, 2020
Updates for flutter/flutter#57238 The new build files use the templates, modified as necessary for dependencies (e.g., GTK).
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
May 16, 2020
Updates for flutter/flutter#57238 The new build files use the templates, modified as necessary for dependencies (e.g., GTK).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Linux templates to use CMake+ninja, rather than Make, and updates the tooling to generate CMake support files rather than Make support files, and to drive the build using
cmakeandninja.Also updates
doctorto check forcmakeandninjain place ofmake.Note: While we could use CMake+Make rather than CMake+ninja, in testing ninja handled the tool_backend.sh call much better, calling it only once rather than once per dependent target. While it does add another dependency that people are less likely to already have, it's widely available in package managers, as well as being available as a direct download. Longer term, we could potentially switch from ninja to Make if it's an issue.
Related Issues
Fixes #52751
Tests
I added the following tests: Mostly just updated tests, but added some to cover the fact that there's one more binary in the workflow now.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.