iOS Text Selection Menu Overflow #54139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failures: commit 84a584249b356aac99bdda16cb570a1cb5d82717 Merge: 16dd2bb50 d35ade4 Author: Justin McCandless <jmccandless@google.com> Date: Mon Apr 6 11:35:54 2020 -0700 Merge branch 'master' into characters commit 16dd2bb50454428e6d52dcc74963595109e79ef6 Author: Justin McCandless <jmccandless@google.com> Date: Mon Apr 6 09:53:29 2020 -0700 More detailed comment after researching caret position commit 9741aa11b9eaf5f0d9a8947dc60a063128960e27 Author: Justin McCandless <jmccandless@google.com> Date: Mon Mar 30 10:19:32 2020 -0700 Error state color shows on textfield at right time with grapheme clusters commit dee3f094aec392b4ee1e85b58511436e6542890b Author: Justin McCandless <jmccandless@google.com> Date: Fri Mar 27 10:43:02 2020 -0700 Combine two test files testing the same file commit 1459a926093721475af91077d5c6f057dba75d35 Author: Justin McCandless <jmccandless@google.com> Date: Fri Mar 27 10:38:16 2020 -0700 Selection is no longer limited to maxLength commit 540632f92898e7002c0b114bdaaf061d317ac630 Author: Justin McCandless <jmccandless@google.com> Date: Fri Mar 27 08:51:08 2020 -0700 Ran update-packages --force-upgrade commit 6a9e95773a546a56c5b59e64e938f7499f087d3b Author: Justin McCandless <jmccandless@google.com> Date: Fri Mar 27 08:35:34 2020 -0700 Grapheme/surrogate tests for truncate commit ad10bb99ca4ffcbfa68f0b3fc4d830a5a20a108f Author: Justin McCandless <jmccandless@google.com> Date: Thu Mar 26 17:19:35 2020 -0700 maxLength limits to characters, not runes commit 42fd9126c74469ac852a0b12be19a597131f5311 Author: Justin McCandless <jmccandless@google.com> Date: Thu Mar 26 16:07:33 2020 -0700 Add characters package and use it for maxLength counter
Contributor
Author
|
Fail - I merged the wrong branch to create this. I'll reopen again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the selection menu buttons are too wide for their available space, they will cause an overflow error. This PR implements the native iOS solution for this problem, which paginates overflowing items.
Related Issues
Closes #35826
Android solution: #49391
Reopened from #52852 to fix weird versioning test failures.
Tests
Breaking Change
None.