Skip to content

iOS Text Selection Menu Overflow #52852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinmc wants to merge 32 commits into from
Closed

iOS Text Selection Menu Overflow #52852

justinmc wants to merge 32 commits into from

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Mar 18, 2020 •
edited
Loading

Description

If the selection menu buttons are too wide for their available space, they will cause an overflow error. This PR implements the native iOS solution for this problem, which paginates overflowing items.

Related Issues

Closes #35826
Android solution: #49391

Tests

  • When all buttons fit on one page.
  • When the screen is narrow enough that only two buttons fit on each page.
  • When the screen is narrow enough that only one button fits on each page.
  • When the locale strings are so long that only one button fits on each page and must be ellided.

Breaking Change

None.

@justinmc justinmc added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Mar 18, 2020
@justinmc justinmc self-assigned this Mar 18, 2020
@fluttergithubbot fluttergithubbot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Mar 18, 2020
@justinmc justinmc force-pushed the selection-overflow-ios branch from de01663 to be69380 Compare March 23, 2020 22:41
@justinmc justinmc force-pushed the selection-overflow-ios branch from 78b8451 to 56122a4 Compare March 25, 2020 18:32
@skia-gold
Copy link

skia-gold commented Mar 25, 2020

Gold has detected one or more untriaged digests on patchset 17.
Please triage them at https://flutter-gold.skia.org/search?issue=52852.

@justinmc justinmc force-pushed the selection-overflow-ios branch from 4157936 to 305e3b9 Compare April 1, 2020 22:31
@justinmc justinmc changed the title (WIP) iOS Text Selection Menu Overflow iOS Text Selection Menu Overflow Apr 3, 2020
@justinmc justinmc requested review from chunhtai and goderbauer April 3, 2020 18:12
@justinmc justinmc mentioned this pull request Apr 6, 2020
Closed
@justinmc
Copy link
Contributor Author

justinmc commented Apr 6, 2020

In order to fix the weird versioning failures closing this in favor of #54139.

@justinmc justinmc closed this Apr 6, 2020
@justinmc justinmc deleted the selection-overflow-ios branch April 6, 2020 20:51
@justinmc justinmc mentioned this pull request Apr 6, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

@chunhtai chunhtai Awaiting requested review from chunhtai

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

text selection toolbar over flow !

4 participants

@justinmc @skia-gold @googlebot @fluttergithubbot