Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Mar 6, 2020

Description

CocoaPods introduced a CDN on 1.8 so the user no longer has to run pod setup. 1.8 has been out since September, so let's bump the minimum recommended version so users get a nudge to upgrade. Minimum required version is still 1.6.0.

Devicelab is already on higher version.

Error looks like:
Screen Shot 2020-03-05 at 6 36 57 PM

Related Issues

#41491
Fixes #25592

Tests

Added recommended version test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Mar 6, 2020
@jmagman jmagman self-assigned this Mar 6, 2020
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit a14ac4e into flutter:master Mar 6, 2020
@jmagman jmagman deleted the cocoapods branch March 6, 2020 20:14
@jmagman jmagman added the platform-ios iOS applications specifically label Aug 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter build fails on pod versioning issue with firebase_storage

3 participants