Skip to content

Skip pod initialization if version >= 1.8.0. #41491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Sep 30, 2019
Merged

Skip pod initialization if version >= 1.8.0. #41491

jmagman merged 2 commits into from
Sep 30, 2019

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 27, 2019

Description

CocoaPods 1.8.0 no longer requires pod setup to be run since it doesn't need the local specs repository set up.

Also remove hard-coded 1.7.5 device lab version since 1.8.1 has fixed the gem issue introduced in 1.8.0.

Related Issues

Fixes #41253.
Fixes #41221.

Tests

Added cocoapods_test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 27, 2019
@jmagman jmagman added t: flutter doctor Problem related to the "flutter doctor" tool team-infra Owned by Infrastructure team platform-ios iOS applications specifically labels Sep 27, 2019
jmagman
jmagman commented Sep 27, 2019
View reviewed changes
.cirrus.yml Outdated
Copy link
Member Author

@jmagman jmagman Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\cc @digiter

@jmagman jmagman mentioned this pull request Sep 27, 2019
Closed
stuartmorgan-g
stuartmorgan-g approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better than my suggestion :)

@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e8517a4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #41491   +/-   ##
=========================================
  Coverage          ?   60.24%           
=========================================
  Files             ?      193           
  Lines             ?    18841           
  Branches          ?        0           
=========================================
  Hits              ?    11350           
  Misses            ?     7491           
  Partials          ?        0
Flag Coverage Δ
#flutter_tool 60.24% <100%> (?)
Impacted Files Coverage Δ
...ackages/flutter_tools/lib/src/macos/cocoapods.dart 90.56% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8517a4...6205750. Read the comment docs.

@jmagman
Copy link
Member Author

jmagman commented Sep 30, 2019

Landing on red tests, issue was fixed 3 days ago with d968b7c.

@jmagman jmagman merged commit 1eb1e22 into flutter:master Sep 30, 2019
@jmagman jmagman deleted the pod branch September 30, 2019 20:14
@BondarenkoStas BondarenkoStas mentioned this pull request Oct 14, 2019
Closed
@zanderso zanderso mentioned this pull request Oct 16, 2019
Merged
zanderso added a commit that referenced this pull request Oct 17, 2019
@zanderso
V1.9.1 hotfixes (#42863)
1aedbb1 
* refactor cocoapods validator to detect broken install (#38560)
* Skip pod initialization if version >= 1.8.0. (#41491)
@jmagman jmagman mentioned this pull request Nov 14, 2019
Closed
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@jmagman @Inconnu08
Skip pod initialization if version >= 1.8.0. (flutter#41491)
bf8e2d8
@jmagman jmagman mentioned this pull request Mar 6, 2020
Merged
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically t: flutter doctor Problem related to the "flutter doctor" tool team-infra Owned by Infrastructure team tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pod setup does not work for Cocoapods 1.8.0 Use CocoaPods version 1.8.1 in devicelab

4 participants

@jmagman @stuartmorgan-g @googlebot @fluttergithubbot