Skip to content

Revert "Call setEditingState when text changes." #47397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingjun merged 1 commit into from
Dec 19, 2019
Merged

Revert "Call setEditingState when text changes." #47397

chingjun merged 1 commit into from
Dec 19, 2019

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Dec 19, 2019

Reverts #47177

Some of the internal tests are broken by this.

@chingjun chingjun requested a review from dnfield December 19, 2019 00:52
@fluttergithubbot fluttergithubbot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 19, 2019
dnfield
dnfield approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've re-opened #47137

@chingjun chingjun merged commit d51956a into master Dec 19, 2019
dnfield added a commit to dnfield/flutter that referenced this pull request Dec 19, 2019
@dnfield
Revert "Revert "Call setEditingState when text changes. (flutter#47177)…
67583db 
…" (flutter#47397)"

This reverts commit d51956a.
@dnfield dnfield deleted the revert-47177-setEditingState branch February 17, 2020 22:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingjun @dnfield @googlebot @fluttergithubbot