Reland: Migrate examples new embedding #43643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-carroll
approved these changes
Oct 28, 2019
| // Triggers the Android keyboard, which causes the resize of the Flutter view. | ||
| // We need to wait for the app to complete. | ||
| MethodChannel(flutterView, "com.example.abstract_method_smoke_test") | ||
| MethodChannel(flutterEngine.getDartExecutor(), "com.example.abstract_method_smoke_test") |
Contributor
There was a problem hiding this comment.
There has been an API change to flutterEngine.getDartExecutor().getBinaryMessenger(). Should we make that change now? Or should we come back later and update?
Author
There was a problem hiding this comment.
will follow up with that while the device lab tests are running.
Contributor
|
Heads up, this commit was flagged as a potential point of regression tracked in #43688 |
blasten
pushed a commit
to blasten/flutter
that referenced
this pull request
Oct 29, 2019
This reverts commit 20e015f.
This was referenced Oct 29, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
* Fix device lab tests * Migrate examples to the Android embedding v2 (flutter#43221)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #43221