Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Oct 21, 2019

Description

Currently cirrus is failing the mac deploy gallery test because fastlane is looking for a version of the Google Cloud SDK newer than that on the docker image. Re-building the docker image is complicated, so I am temporarily commenting out the offending step. Note, that this test will still fail on the next published release until the issue is resolved: #43204.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review labels Oct 21, 2019
@christopherfujino christopherfujino force-pushed the remove-fastlane branch 3 times, most recently from 86ab2b7 to 36859d8 Compare October 21, 2019 21:13
@christopherfujino christopherfujino marked this pull request as ready for review October 21, 2019 21:18
@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #43207 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43207      +/-   ##
==========================================
- Coverage   61.13%   61.07%   -0.06%     
==========================================
  Files         195      195              
  Lines       18954    18954              
==========================================
- Hits        11587    11577      -10     
- Misses       7367     7377      +10
Flag Coverage Δ
#flutter_tool 61.07% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
...s/flutter_tools/lib/src/tester/flutter_tester.dart 32.65% <0%> (-39.8%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 69.64% <0%> (-16.08%) ⬇️
...ages/flutter_tools/lib/src/test/test_compiler.dart 53.42% <0%> (-15.07%) ⬇️
...ages/flutter_tools/lib/src/linux/linux_doctor.dart 80% <0%> (-10%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 64.82% <0%> (-4.49%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 77.92% <0%> (-3.9%) ⬇️
packages/flutter_tools/lib/src/version.dart 93.23% <0%> (-1.94%) ⬇️
packages/flutter_tools/lib/src/cache.dart 48.47% <0%> (-0.71%) ⬇️
packages/flutter_tools/lib/src/device.dart 67.46% <0%> (-0.61%) ⬇️
packages/flutter_tools/lib/src/macos/xcode.dart 61.66% <0%> (+10%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584ee10...36859d8. Read the comment docs.

@fkorotkov
Copy link
Contributor

FYI you can use Dockerfile as CI Environment with Cirrus for easier upgrades.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor Author

deploy_gallery-macos passed, so I will land this

@christopherfujino christopherfujino merged commit 898e6fe into flutter:master Oct 21, 2019
@christopherfujino christopherfujino deleted the remove-fastlane branch October 21, 2019 22:26
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fastlane fails in deploy_gallery test because dependencies outdated

5 participants