-
Notifications
You must be signed in to change notification settings - Fork 29.8k
comment out fastlane test archiving #43207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
86ab2b7 to
36859d8
Compare
Codecov Report
@@ Coverage Diff @@
## master #43207 +/- ##
==========================================
- Coverage 61.13% 61.07% -0.06%
==========================================
Files 195 195
Lines 18954 18954
==========================================
- Hits 11587 11577 -10
- Misses 7367 7377 +10
Continue to review full report at Codecov.
|
|
FYI you can use Dockerfile as CI Environment with Cirrus for easier upgrades. |
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
deploy_gallery-macos passed, so I will land this |
Description
Currently cirrus is failing the mac deploy gallery test because fastlane is looking for a version of the Google Cloud SDK newer than that on the docker image. Re-building the docker image is complicated, so I am temporarily commenting out the offending step. Note, that this test will still fail on the next published release until the issue is resolved: #43204.