Skip to content

Incorporating Link Semantics #41327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piinks merged 18 commits into from
Oct 9, 2019
Merged

Incorporating Link Semantics #41327

Piinks merged 18 commits into from
Oct 9, 2019

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Sep 25, 2019 •
edited
Loading

Description

Incorporates link specific semantics. Dependent on engine change:
flutter/engine#12453
flutter/engine#12972
flutter/engine#13001
flutter/engine#13009

Will require a manual engine roll.

This change also incorporates the link semantics with TextSpans that use TapGestureRecognizers.

Related Issues

Part of #36306

Tests

Updated semantics related tests.
Added test to check that the SemanticsFlag.isLink is added properly to relevant TextSpans

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Sep 25, 2019
@Piinks Piinks mentioned this pull request Sep 25, 2019
Merged
@Piinks Piinks marked this pull request as ready for review September 30, 2019 17:27
@Piinks Piinks changed the title [WIP] Adding Link SemanticsFlag Incorporating Link Semantics Sep 30, 2019
goderbauer
goderbauer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the two nits.

@Piinks Piinks mentioned this pull request Oct 4, 2019
Merged
8 tasks
@Piinks Piinks mentioned this pull request Oct 7, 2019
Merged
@Piinks
Copy link
Contributor Author

Piinks commented Oct 7, 2019

Will need to update the engine version after flutter/engine#12972 lands

@Piinks Piinks mentioned this pull request Oct 8, 2019
Merged
@Piinks Piinks mentioned this pull request Oct 8, 2019
Merged
@Piinks
Copy link
Contributor Author

Piinks commented Oct 9, 2019

Landing on red to fix the build. :D

@Piinks Piinks merged commit 1ec44a0 into flutter:master Oct 9, 2019
@Piinks Piinks deleted the linkA11y branch October 9, 2019 01:16
@pavariss pavariss mentioned this pull request Oct 10, 2019
Closed
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@Piinks @Inconnu08
Incorporating Link Semantics (flutter#41327)
6b18cf5
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @goderbauer @googlebot @fluttergithubbot