Skip to content

Added notice to docs that setPreferredOrientations does not always work on iPad #40743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 5 commits into from
Oct 2, 2019
Merged

Added notice to docs that setPreferredOrientations does not always work on iPad #40743

goderbauer merged 5 commits into from
Oct 2, 2019

Conversation

@josh-ksr
Copy link
Contributor

@josh-ksr josh-ksr commented Sep 18, 2019

Description

Added a notice to the documentation that setPreferredOrientations does not always work on iPad

Related Issues

#27235

Tests

I added the following tests:

No tests as I only changed documentation

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 18, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 18, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer
goderbauer reviewed Sep 18, 2019
View reviewed changes
@josh-ksr josh-ksr requested a review from goderbauer September 19, 2019 10:33
@josh-ksr josh-ksr mentioned this pull request Sep 24, 2019
Merged
goderbauer
goderbauer reviewed Sep 25, 2019
View reviewed changes
@Piinks Piinks added the d: api docs Issues with https://api.flutter.dev/ label Sep 30, 2019
Piinks
Piinks approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer merged commit 8b9e144 into flutter:master Oct 2, 2019
@DanTup DanTup mentioned this pull request Oct 15, 2019
Closed
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@josh-ksr @Inconnu08
Added notice to docs that setPreferredOrientations does not always wo…
f0b266f 
…rk on iPad (flutter#40743)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer left review comments

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josh-ksr @fluttergithubbot @goderbauer @Piinks @googlebot