Exclude non Android plugins from Gradle build #40640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
Sep 17, 2019
| Properties allPlugins = readPropertiesIfExist(pluginsFile) | ||
| Properties androidPlugins = new Properties() | ||
| allPlugins.each { name, path -> | ||
| File editableAndroidProject = new File(path, 'android' + File.pathSeparator + 'build.gradle') |
There was a problem hiding this comment.
nit: File.separator instead of File.pathSeparator. This should fix the tests that are failing.
| allPlugins.each { name, path -> | ||
| File editableAndroidProject = new File(path, 'android' + File.pathSeparator + 'build.gradle') | ||
| if (editableAndroidProject.exists()) { | ||
| project.logger.error("$editableAndroidProject exists adding $name -> $path") |
| Properties androidPlugins = new Properties() | ||
| allPlugins.each { name, path -> | ||
| File editableAndroidProject = new File(path, 'android' + File.separator + 'build.gradle') | ||
| if (editableAndroidProject.exists()) { |
Contributor
There was a problem hiding this comment.
I think we might want to print some sort of warning here. Assuming that we can fix the platform specific .flutter-plugins issue, this would still be an error.
Contributor
Author
There was a problem hiding this comment.
Not sure what I can do as part of this CL...?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Print a warning when? both cases (having an android/build.gradle and not having it are legit...)
Contributor
There was a problem hiding this comment.
print a warning when it is missing. You're right for now that isn't an error because it is unavoidable. Maybe leave a todo so we can revisit it in the future.
81da48d to
8026b0e
Compare
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Before this change, having an Android app depend on a plugin that has no android implementation resulted in a Gradle build failure. This scenario is likely to become more common if we're enabling federated plugins, as the package implementing just the desktop implementation of a plugin won't have an Android implementation. This changes the Gradle plugin to not try to build any plugins that doesn't have an android/build.gradle file.
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter-desktop-embedding
that referenced
this pull request
Sep 30, 2019
As of flutter/flutter#40640 these should no longer be necessary. Also fixes a typo in a plugin pubspec.yaml.
stuartmorgan-g
added a commit
to google/flutter-desktop-embedding
that referenced
this pull request
Oct 1, 2019
As of flutter/flutter#40640 these should no longer be necessary. Also fixes a typo in a plugin pubspec.yaml.
This was referenced Dec 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, having an Android app depend on a plugin that has no android implementation resulted in a Gradle build failure.
This scenario is likely to become more common if we're enabling federated plugins, as the package implementing just the desktop implementation of a plugin won't have an Android implementation.
This changes the Gradle plugin to not try to build any plugins that doesn't have an
android/build.gradlefile.Related Issues
#39657
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?