Propagate textfield character limits to semantics #40468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
We should specify exactly what we mean by "characters" here
jonahwilliams
approved these changes
Sep 14, 2019
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM with nit.
We should be very specific about how the framework counts characters here.
a154826 to
0a3cf58
Compare
751b1f1 to
5726b77
Compare
goderbauer
added a commit
that referenced
this pull request
Sep 17, 2019
This reverts commit 6ad88bd.
goderbauer
added a commit
that referenced
this pull request
Sep 17, 2019
goderbauer
added a commit
to goderbauer/flutter
that referenced
this pull request
Sep 18, 2019
…utter#40468)" (flutter#40714)" This reverts commit b4324ae.
9 tasks
goderbauer
added a commit
that referenced
this pull request
Sep 18, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
)" (flutter#40714) This reverts commit 6ad88bd.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What the title says. Corresponding engine change: flutter/engine#12269.
Also fixes an issue where you could interact with a disabled textfield via talkback.
Related Issues
Fixes #38940.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?