Skip to content

Flip the default for proguard #40282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 1 commit into from
Sep 12, 2019
Merged

Flip the default for proguard #40282

blasten merged 1 commit into from
Sep 12, 2019

Conversation

@blasten
Copy link

@blasten blasten commented Sep 11, 2019 •
edited
Loading

Description

Changes the --proguard default to false for flutter build apk and flutter build appbundle until addressing proguard rules for plugins.

Test that broke: https://cirrus-ci.com/task/4835793194975232?command=main

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 11, 2019
@blasten blasten requested a review from amirh September 11, 2019 21:18
amirh
amirh approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's mention that test that was broken in the PR description

@codecov
Copy link

codecov bot commented Sep 11, 2019 •
edited
Loading

Codecov Report

Merging #40282 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40282      +/-   ##
==========================================
- Coverage   58.54%   58.51%   -0.03%     
==========================================
  Files         192      192              
  Lines       18549    18543       -6     
==========================================
- Hits        10860    10851       -9     
- Misses       7689     7692       +3
Flag Coverage Δ
#flutter_tool 58.51% <ø> (-0.03%) ⬇️
Impacted Files Coverage Δ
...ages/flutter_tools/lib/src/commands/build_apk.dart 100% <ø> (ø) ⬆️
...lutter_tools/lib/src/commands/build_appbundle.dart 100% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/emulator.dart 21.18% <0%> (-48.31%) ⬇️
...kages/flutter_tools/lib/src/ios/ios_emulators.dart 8% <0%> (-44%) ⬇️
...flutter_tools/lib/src/android/android_builder.dart 12.5% <0%> (-34.38%) ⬇️
...ools/lib/src/build_runner/resident_web_runner.dart 44.52% <0%> (-33.57%) ⬇️
...ackages/flutter_tools/lib/src/commands/config.dart 72% <0%> (-14.67%) ⬇️
packages/flutter_tools/lib/src/android/gradle.dart 61.52% <0%> (-12.97%) ⬇️
...lutter_tools/lib/src/android/android_emulator.dart 53.06% <0%> (-10.21%) ⬇️
...ges/flutter_tools/lib/src/android/android_sdk.dart 73.78% <0%> (-3%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d37867...a46b142. Read the comment docs.

This was referenced Sep 11, 2019
Merged
Merged
@blasten blasten merged commit 3712ea6 into flutter:master Sep 12, 2019
@blasten blasten deleted the change_default_proguard branch September 12, 2019 00:51
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Flip the default for proguard (flutter#40282)
10ab218
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amirh amirh amirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @amirh @googlebot @fluttergithubbot