Manual roll of engine 45b66b7...ffba2f6 #35464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git log 45b66b7...ffba2f6 --oneline ffba2f6 Roll src/third_party/dart b37aa3b036...0abff7b2bb (flutter#9588) 62514cb Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (flutter#9587) 9f27212 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter#9586) 03a31e0 Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter#9583)
bkonyi
approved these changes
Jul 2, 2019
Contributor
|
This seems to break ~10 build bots: https://flutter-dashboard.appspot.com/build.html. Shall we revert? |
Contributor
Author
|
A fix for the breaks has been submitted on top of this. |
Contributor
|
This yielded a significant regression in the following benchmarks:
@a-siva can you please investigate? |
Contributor
|
Looks like a 200-250ms regression in hot reload times on Linux and Mac. |
Contributor
|
We're tracking the regression here: #35551 |
tango5614
added a commit
to tango5614/flutter
that referenced
this pull request
Jul 4, 2019
* commit 'a0c47e2216a2b50b70c478001cf5652f31a783af': (187 commits) Do not use ideographic baseline for RenderPargraph baseline (flutter#35493) Add type to StreamChannel in generated test code. (flutter#35367) Fix RenderFittedBox when child.size.isEmpty (flutter#35487) add APK build time benchmarks (flutter#35481) fix Selection handles position is off (flutter#34665) Move usage flutter create tests into memory filesystem. (flutter#35160) Include tags in SemanticsNode debug properties (flutter#35491) Re-apply 'Add currentSystemFrameTimeStamp to SchedulerBinding' (flutter#35492) CupertinoTextField vertical alignment (flutter#34723) Mark update-packages as non-experimental (flutter#35467) fix default artifacts to exclude ios and android (flutter#35303) Roll engine ffba2f6..7d3e722 (59 commits) (flutter#35489) Update macrobenchmarks README and app name (flutter#35477) mark windows and macos chrome dev mode as flaky (flutter#35495) Use the new service protocol message names (flutter#35482) Manual roll of engine 45b66b7...ffba2f6 (flutter#35464) more ui-as-code (flutter#35393) update reassemble doc (flutter#35164) New parameter for RawGestureDetector to customize semantics mapping (flutter#33936) Add --target support for Windows and Linux (flutter#34660) ...
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
* Manual roll of engine 45b66b7...ffba2f6 git log 45b66b7...ffba2f6 --oneline ffba2f6 Roll src/third_party/dart b37aa3b036...0abff7b2bb (flutter#9588) 62514cb Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (flutter#9587) 9f27212 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter#9586) 03a31e0 Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter#9583) * Fix analyzer warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git log 45b66b7...ffba2f6 --oneline
ffba2f6 Roll src/third_party/dart b37aa3b036...0abff7b2bb (flutter/engine#9588)
62514cb Roll fuchsia/sdk/core/mac-amd64 from n9fZpXVmsbgKZzS8Q2GXxB453q8AbLpfGztsPsq47pMC to BYCwsJf7r7zfd2THSGinFeIHv552AEVchXdc7VZzP0IC (flutter/engine#9587)
9f27212 Roll src/third_party/skia e4c88bb1f848..1ddee025229a (7 commits) (flutter/engine#9586)
03a31e0 Roll fuchsia/sdk/core/linux-amd64 from F9oY0d56X3aONxwv5vw9Gco--AHmC8SHuDXdhdWCnnMC to d2VK3FYSEKQ35UdZw5FdbOZUI_xgT0-1h8DnGDUHPVAC (flutter/engine#9583)