Skip to content

Ensures flutter jar is added to all build types on plugin projects #34573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 10 commits into from
Jun 25, 2019
Merged

Ensures flutter jar is added to all build types on plugin projects #34573

blasten merged 10 commits into from
Jun 25, 2019

Conversation

@josh-burton
Copy link
Contributor

@josh-burton josh-burton commented Jun 17, 2019 •
edited
Loading

Description

The flutter jar is currently only added to debug/profile/release build types for plugin projects.

Plugin projects could have extra build types, or an app could add extra build types to all subprojects:

subprojects {
	android.buildTypes {
		debug {}
        staging {}
        release {}
	}
}

This causes compilation failures as the plugin projects can't find Flutter classes.

Related Issues

#34089

Tests

Added a test to gradle_plugin_light_apk_test.dart which tests building an android app containing custom build types in all subprojects (i.e. plugins)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@blasten Requesting your review on this one :)

@Piinks Piinks added t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 17, 2019
@josh-burton
Copy link
Contributor Author

josh-burton commented Jun 17, 2019

This may require some rework once #34592 is merged to keep the logic consistent.

@josh-burton
Copy link
Contributor Author

josh-burton commented Jun 20, 2019

@blasten this PR is ready to go now, would you mind taking a look?

@josh-burton
Copy link
Contributor Author

josh-burton commented Jun 21, 2019

@dnfield @matthew-carroll who is the best person to review this?

@matthew-carroll
Copy link
Contributor

matthew-carroll commented Jun 21, 2019

Probably @blasten

blasten
blasten reviewed Jun 21, 2019
View reviewed changes
@josh-burton
Copy link
Contributor Author

josh-burton commented Jun 21, 2019

Thanks for the review @blasten, I've addressed all of the comments.

blasten
blasten approved these changes Jun 21, 2019
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@blasten
Copy link

blasten commented Jun 25, 2019

It looks like this breaks one of the smoke tests.

@dnfield
Copy link
Contributor

dnfield commented Jun 25, 2019

I think that test is failing because of an unrelated issue - it should be safe to ignore, and should pass on post submit.

@dnfield
Copy link
Contributor

dnfield commented Jun 25, 2019

(The contributor isn't able to access the encrypted variable)

@blasten
Copy link

blasten commented Jun 25, 2019 •
edited
Loading

Gotcha. Thanks @dnfield! Merging on red as per Dan's comment.

@blasten blasten merged commit 577c2fc into flutter:master Jun 25, 2019
@dnfield
Copy link
Contributor

dnfield commented Jun 25, 2019

The test passed on post submit. We should probably improve this test so that it doesn't fail if the JSON is invalid for the service account, or at least somehow make the test itself make it clear that it failed but is safe to ignore.

johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@josh-burton @johnsonmh
Ensures flutter jar is added to all build types on plugin projects (f…
d8a24d4 
…lutter#34573)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

t: gradle "flutter build" and "flutter run" on Android tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@josh-burton @matthew-carroll @blasten @dnfield @googlebot @Piinks