Skip to content

Add missing pieces for 'driver' support on macOS #34376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stuartmorgan-g merged 6 commits into from
Jun 18, 2019
Merged

Add missing pieces for 'driver' support on macOS #34376

stuartmorgan-g merged 6 commits into from
Jun 18, 2019

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Jun 13, 2019

Description

  • Adds desktop projects to ApplicationPackageStore
  • Plumbs target overrides through the desktop builds

Related Issues

None

Tests

I added the following tests: None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@stuartmorgan-g
Add missing pieces for 'driver' support on desktop
d70982f 
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the desktop builds
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Jun 13, 2019

I've verified that this is enough to make flutter-driver work for macOS. I haven't tested Windows or Linux yet, but the corresponding pieces were obviously missing there as well so I added them at the same time.

jonahwilliams
jonahwilliams approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter_tools/lib/src/application_package.dart
MacOSApp macOS;
WindowsApp windows;

Future<ApplicationPackage> getPackageForPlatform(TargetPlatform platform) async {
Copy link
Contributor

@jonahwilliams jonahwilliams Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could a simple smoke test here by asserting that the returned value for a particular platform is non-null

@Piinks Piinks added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 13, 2019
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Jun 13, 2019

I ended up having to touch more files; lib/main.dart was hard-coded in a few places in the tooling rather than using path.join which made things unhappy on Windows.

@stuartmorgan-g stuartmorgan-g changed the title Add missing pieces for 'driver' support on desktop Add missing pieces for 'driver' support on macOS Jun 18, 2019
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Jun 18, 2019

In the interest of unblocking the macOS support, so that people can start using it on at least one platform, I've narrowed the scope of this to just macOS and removed the path.join change. I'll do a follow-up with Linux and Windows.

@stuartmorgan-g stuartmorgan-g merged commit cc541e6 into flutter:master Jun 18, 2019
@stuartmorgan-g stuartmorgan-g deleted the desktop-driver-support branch June 18, 2019 18:14
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jun 18, 2019
Merged
9 tasks
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@stuartmorgan-g @johnsonmh
Add missing pieces for 'driver' support on macOS (flutter#34376)
1d64382 
- Adds desktop projects to ApplicationPackageStore
- Plumbs target overrides through the macOS build
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stuartmorgan-g @jonahwilliams @googlebot @Piinks