Revert "Roll engine to 086b5a48d6acdb64dd7b2a4cbf9dd620c54812b9" #34085
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jun 7, 2019
Member
|
The integration_ui/keyboard_resize test regression started with flutter/engine@e80df36. Prior to adding keyboard support for platform views However, the framework will call |
Contributor
|
LGTM |
amirh
added a commit
to flutter/engine
that referenced
this pull request
Jun 10, 2019
#9203 broke the keyboard_resize integration test(see more details in flutter/flutter#34085 (comment)). This re-lands @9203 and fixes the issue the integration test uncovered by always allowing to hide the keyboard. The difference from the original change is 07d2598
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
…lutter#9257) flutter#9203 broke the keyboard_resize integration test(see more details in flutter/flutter#34085 (comment)). This re-lands @9203 and fixes the issue the integration test uncovered by always allowing to hide the keyboard. The difference from the original change is 07d2598
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #34062
On integration_ui:
2019-06-07T16:41:33.267: stderr: [ +14 ms] [trace] FlutterDriver: Waiting for service extension
2019-06-07T16:41:36.003163: stderr: [+2736 ms] [info ] FlutterDriver: Connected to Flutter application.
2019-06-07T16:41:36.009010: stdout: [ +6 ms] 00:03 �[32m+0�[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size�[0m
2019-06-07T16:41:38.839062: stdout: [+2830 ms] 00:06 �[32m+0�[0m�[31m -1�[0m: end-to-end test Ensure keyboard dismissal resizes the view to original size �[1m�[31m[E]�[0m�[0m
2019-06-07T16:41:38.839228: stdout: [ ] Expected: '592.0'
2019-06-07T16:41:38.839351: stdout: [ ] Actual: '343.0'
2019-06-07T16:41:38.839612: stdout: [ ] Which: is different.
stdout: [ ] Expected: 592.0
2019-06-07T16:41:38.839819: stdout: [ ] Actual: 343.0
2019-06-07T16:41:38.840088: stdout: [ ] ^
2019-06-07T16:41:38.840184: stdout: [ ] Differ at offset 0
2019-06-07T16:41:38.860085: stdout: [ +19 ms] package:test_api/src/frontend/expect.dart 152:30 fail
2019-06-07T16:41:38.860424: stdout: [ ] package:test_api/src/frontend/expect.dart 146:3 _expect
stdout: [ ] package:test_api/src/frontend/expect.dart 59:3 expect
2019-06-07T16:41:38.860981: stdout: [ ] test_driver/keyboard_resize_test.dart 51:7 main..
stdout: [ ] ===== asynchronous gap ===========================
stdout: [ ] dart:async/future_impl.dart 22:43 _Completer.completeError
2019-06-07T16:41:38.861512: stdout: [ ] dart:async-patch/async_patch.dart 40:18 _AsyncAwaitCompleter.completeError
stdout: [ ] test_driver/keyboard_resize_test.dart main..
stdout: [ ] ===== asynchronous gap ===========================
2019-06-07T16:41:38.862435: stdout: [ ] dart:async/zone.dart 1053:19 _CustomZone.registerUnaryCallback
stdout: [ ] dart:async-patch/async_patch.dart 77:23 _asyncThenWrapperHelper
stdout: [ ] test_driver/keyboard_resize_test.dart main..
stdout: [ ] package:test_api/src/backend/declarer.dart 168:27 Declarer.test...
stdout: [ ] ===== asynchronous gap ===========================
stdout: [ ] dart:async/zone.dart 1053:19 _CustomZone.registerUnaryCallback