Splitting golden file versioning out as an argument of matchesGoldenFile #33880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Jun 14, 2019
| key | ||
| .toString() | ||
| .splitMapJoin( | ||
| RegExp(r'.png'), |
Member
There was a problem hiding this comment.
Do we know that these will always be .png? What about using the path packages to just split off any extension?
Contributor
Author
There was a problem hiding this comment.
When we do the binding for a golden test, we have it write out in png format. See here:
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
…ile (flutter#33880) * Splitting golden file versioning out as an argument of matchesGoldenFile * Fixing description implementation. * Removing unused imports * Removing unused import * Review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the optional
versionparameter to thematchesGoldenFilefunction. This is not a breaking change, and maintains testing fidelity with flutter/goldens.The reason for this change is the forthcoming integration of Skia Gold for golden file testing (#33688). This establishes a clean, uniform naming structure for golden file tests, that will work in both systems, past and future, during the interim.
Documentation of this change needs to be done before landing, but not until changes are approved.
Related Issues
Dependent on:
#33865✅Fixes #33813
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?