Skip to content

Instrument add to app flows#33297

Merged
blasten merged 8 commits into
flutter:masterfrom
blasten:add_to_app_measurement
May 28, 2019
Merged

Instrument add to app flows#33297
blasten merged 8 commits into
flutter:masterfrom
blasten:add_to_app_measurement

Conversation

@blasten

@blasten blasten commented May 24, 2019 •
edited
Loading

Copy link
Copy Markdown

Description

Instrument add to app flows, so we can get an estimate of how the tool is used in this context.

Related Issues

#32649

Tests

I added the following tests:

  • Test for project.ios.isSwift and project.android.isKotlin
  • test/commands/create_test.dart, test/commands/packages_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@blasten blasten force-pushed the add_to_app_measurement branch from d64a16f to de70e1c Compare May 24, 2019 06:25
@blasten blasten added a: existing-apps Integration with existing apps via the add-to-app flow tool Affects the "flutter" command-line tool. See also t: labels. labels May 24, 2019
@blasten blasten requested review from jonahwilliams and xster May 24, 2019 06:28
@blasten blasten force-pushed the add_to_app_measurement branch from de70e1c to 022131d Compare May 24, 2019 06:33
xster
xster reviewed May 24, 2019
View reviewed changes

@xster xster left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. LGTM. Please let Jonah review as well for tooling intricacies.

Comment thread packages/flutter_tools/lib/src/commands/create.dart Outdated
Comment thread packages/flutter_tools/lib/src/commands/create.dart Outdated
Comment thread packages/flutter_tools/lib/src/commands/create.dart
Comment thread packages/flutter_tools/lib/src/commands/create.dart
Comment thread packages/flutter_tools/lib/src/commands/packages.dart Outdated
Comment thread packages/flutter_tools/test/project_test.dart
jonahwilliams
jonahwilliams reviewed May 27, 2019
View reviewed changes
Comment thread packages/flutter_tools/lib/src/commands/attach.dart Outdated
@blasten blasten force-pushed the add_to_app_measurement branch from a367a89 to 2f2a58c Compare May 28, 2019 01:36
@blasten blasten requested a review from jonahwilliams May 28, 2019 02:26
jonahwilliams
jonahwilliams approved these changes May 28, 2019
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit faec4ca into flutter:master May 28, 2019
@blasten blasten deleted the add_to_app_measurement branch May 28, 2019 18:11
jonahwilliams pushed a commit that referenced this pull request May 28, 2019
Revert "Instrument add to app flows (#33297)"
bcb71ab 
This reverts commit faec4ca.
@jonahwilliams jonahwilliams mentioned this pull request May 28, 2019
Merged
jonahwilliams pushed a commit that referenced this pull request May 28, 2019
Revert "Instrument add to app flows (#33297)" (#33449)
8e3e0a8 
This reverts commit faec4ca.
@jason-simmons jason-simmons mentioned this pull request May 28, 2019
Merged
@blasten blasten restored the add_to_app_measurement branch May 28, 2019 21:32
blasten pushed a commit to blasten/flutter that referenced this pull request May 30, 2019
@blasten
Revert "Instrument add to app flows (flutter#33297)" (flutter#33449)
f98fc80 
This reverts commit faec4ca.
@jmagman jmagman mentioned this pull request Dec 12, 2019
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster xster left review comments
+1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: existing-apps Integration with existing apps via the add-to-app flow tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @xster @jonahwilliams @googlebot