Skip to content

Conversation

@xster
Copy link
Member

@xster xster commented Apr 26, 2019

Fixes #13452

When making change suggestions, please double check in iOS so I can justify it with our translators.

@xster xster requested a review from HansMuller April 26, 2019 05:02
@goderbauer goderbauer added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 29, 2019
@xster
Copy link
Member Author

xster commented May 1, 2019

Pending another xml push into TC before pulling again

@xster xster changed the title Push translations from TC Cupertino localization step 12: push translation for all supported languages May 3, 2019
@xster xster added the a: internationalization Supporting other languages or locales. (aka i18n) label May 3, 2019
@@ -0,0 +1,22 @@
{
"todayLabel": "a temporary hack",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latin script in this file is a placeholder while the remaining 3 strings are being translated

@@ -0,0 +1,22 @@
{
"todayLabel": "a temporary hack",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latin script in this file is a placeholder while the remaining 3 strings are being translated

Copy link

@lgfranco lgfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the changes to reflect the iOS in pt and pt_PT

@@ -0,0 +1,22 @@
{
"todayLabel": "Hoje",
"datePickerHourSemanticsLabelOne": "$hour em ponto",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$hour hora"

Suggested change
"datePickerHourSemanticsLabelOne": "$hour em ponto",
"datePickerHourSemanticsLabelOne": "$hour hora",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for diff'ing and reviewing. We'll backport these into the translation console

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are both for brazilian and portugal portuguese?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the use of "em ponto" is not for this situation.

The use wold be for something like 8 o'clock (8 "horas em ponto").

"timerPickerHourLabelOther": "horas",
"timerPickerMinuteLabelOne": "min",
"timerPickerMinuteLabelOther": "min",
"timerPickerSecondLabelOne": "s",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct would be s but the iOS writes "seg" in this locale.

Suggested change
"timerPickerSecondLabelOne": "s",
"timerPickerSecondLabelOne": "seg",

"timerPickerHourLabelOther": "horas",
"timerPickerMinuteLabelOne": "min",
"timerPickerMinuteLabelOther": "min",
"timerPickerSecondLabelOne": "seg",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"timerPickerSecondLabelOne": "seg",
"timerPickerSecondLabelOne": "s",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're suggesting opposite things between here and the same label in the previous file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for some reason the iOS abbreviates seconds in different ways in pt and pt_PT.

I changed my iPhone to pt_PT, accessed the Timer (in the clock App), and used the strings I found there.

"timerPickerMinuteLabelOne": "min",
"timerPickerMinuteLabelOther": "min",
"timerPickerSecondLabelOne": "seg",
"timerPickerSecondLabelOther": "seg",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"timerPickerSecondLabelOther": "seg",
"timerPickerSecondLabelOther": "s",

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Translation feedback will have to be funneled through the Google TC

@lgfranco
Copy link

lgfranco commented May 7, 2019

@xster
Copy link
Member Author

xster commented May 10, 2019

I'm merging this one in for now. The feedback received will cycle through via another update once the TC translations are internalized.

@xster xster merged commit 10922df into flutter:master May 10, 2019
@xster xster deleted the push branch May 10, 2019 06:19
xster added a commit that referenced this pull request May 10, 2019
xster added a commit that referenced this pull request May 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need Cupertino Translations

6 participants