-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Cupertino localization step 12: push translation for all supported languages #31644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pending another xml push into TC before pulling again |
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "a temporary hack", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latin script in this file is a placeholder while the remaining 3 strings are being translated
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "a temporary hack", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latin script in this file is a placeholder while the remaining 3 strings are being translated
lgfranco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes to reflect the iOS in pt and pt_PT
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "todayLabel": "Hoje", | |||
| "datePickerHourSemanticsLabelOne": "$hour em ponto", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"$hour hora"
| "datePickerHourSemanticsLabelOne": "$hour em ponto", | |
| "datePickerHourSemanticsLabelOne": "$hour hora", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for diff'ing and reviewing. We'll backport these into the translation console
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume these are both for brazilian and portugal portuguese?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the use of "em ponto" is not for this situation.
The use wold be for something like 8 o'clock (8 "horas em ponto").
| "timerPickerHourLabelOther": "horas", | ||
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct would be s but the iOS writes "seg" in this locale.
| "timerPickerSecondLabelOne": "s", | |
| "timerPickerSecondLabelOne": "seg", |
| "timerPickerHourLabelOther": "horas", | ||
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "seg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "timerPickerSecondLabelOne": "seg", | |
| "timerPickerSecondLabelOne": "s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you're suggesting opposite things between here and the same label in the previous file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for some reason the iOS abbreviates seconds in different ways in pt and pt_PT.
I changed my iPhone to pt_PT, accessed the Timer (in the clock App), and used the strings I found there.
| "timerPickerMinuteLabelOne": "min", | ||
| "timerPickerMinuteLabelOther": "min", | ||
| "timerPickerSecondLabelOne": "seg", | ||
| "timerPickerSecondLabelOther": "seg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "timerPickerSecondLabelOther": "seg", | |
| "timerPickerSecondLabelOther": "s", |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Translation feedback will have to be funneled through the Google TC
|
pt_PT examples pt examples |
|
I'm merging this one in for now. The feedback received will cycle through via another update once the TC translations are internalized. |
Fixes #13452
When making change suggestions, please double check in iOS so I can justify it with our translators.