Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 17, 2019

Description

For flutter run on a macos target, invoke the build script if not running from a prebuilt application. Update the application package to call the name script, and otherwise proceed with the run as normal

Related Issues

#30707

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jonahwilliams jonahwilliams added e: desktop platform-mac Building on or for macOS specifically labels Apr 17, 2019
@jonahwilliams jonahwilliams changed the title [WIP] Add run capability for macOS target Add run capability for macOS target Apr 17, 2019
stuartmorgan-g added a commit to stuartmorgan-g/flutter-desktop-embedding that referenced this pull request Apr 17, 2019
This enables the placeholder 'flutter run' support; see
flutter/flutter#31218
stuartmorgan-g pushed a commit to google/flutter-desktop-embedding that referenced this pull request Apr 17, 2019
This enables the placeholder 'flutter run' support; see
flutter/flutter#31218
@jonahwilliams jonahwilliams merged commit da92fc1 into flutter:master Apr 18, 2019
@jonahwilliams jonahwilliams deleted the add_desktop_run branch April 18, 2019 05:40
@stuartmorgan-g stuartmorgan-g added the a: desktop Running on desktop label Jul 26, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: desktop Running on desktop platform-mac Building on or for macOS specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants