Skip to content

Revert 26001 #28032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xster merged 1 commit into from
Feb 20, 2019
Merged

Revert 26001 #28032

xster merged 1 commit into from
Feb 20, 2019

Conversation

@xster
Copy link
Member

@xster xster commented Feb 16, 2019

Reverting so it can be discussed more

@xster xster requested a review from Hixie February 16, 2019 00:14
@xster xster added the c: API break Backwards-incompatible API changes label Feb 16, 2019
@xster xster mentioned this pull request Feb 16, 2019
Merged
@zoechi zoechi added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Feb 17, 2019
goderbauer
goderbauer approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster xster merged commit 39b1ff1 into flutter:master Feb 20, 2019
@xster xster deleted the revert branch February 20, 2019 23:34
@kf6gpe kf6gpe mentioned this pull request Feb 23, 2019
Merged
kf6gpe added a commit that referenced this pull request Feb 23, 2019
@kf6gpe
V1.2.1 hotfix.1 --- cherry-pick (#28372)
c509a6e 
* revert 26001 (#28032)

* Rename SuperellipseShare ContinuousRectangleBorder (#28183)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: API break Backwards-incompatible API changes f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xster @goderbauer @zoechi @googlebot