Skip to content

Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)" #27045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jason-simmons merged 1 commit into from
Jan 24, 2019
Merged

Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)" #27045

jason-simmons merged 1 commit into from
Jan 24, 2019

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jan 24, 2019

This reverts commit 30f33d6.

@jason-simmons
Copy link
Member Author

jason-simmons commented Jan 24, 2019

The change of the main script to 3.3.0 needs to be staged along with updates to other users like the Flutter plugins

@jason-simmons jason-simmons requested a review from mklim January 24, 2019 21:51
mklim
mklim approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jason-simmons jason-simmons merged commit 7bfbc28 into flutter:master Jan 24, 2019
@zoechi zoechi added c: contributor-productivity Team-specific productivity, code health, technical debt. t: gradle "flutter build" and "flutter run" on Android labels Jan 25, 2019
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@jason-simmons @kangwang1988
Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (fl…
056d55c 
…utter#26913)" (flutter#27045)

This reverts commit 30f33d6.
@dnfield
Copy link
Contributor

dnfield commented Apr 9, 2019

Can this be relanded? I don't fully recall the problem it caused.

@bradyt
Copy link

bradyt commented Jun 15, 2019

This issue is noisy in logs, for example,

WARNING: API 'variantOutput.getProcessResources()' is obsolete and has been replaced with 'variantOutput.getProcessResourcesProvider()'.
It will be removed at the end of 2019.
For more information, see https://d.android.com/r/tools/task-configuration-avoidance.
REASON: Called from: ~/opt/flutter/packages/flutter_tools/gradle/flutter.gradle:422
WARNING: Debugging obsolete API calls can take time during configuration. It's recommended to not keep it on at all times.
Affected Modules: app

Can someone fix this?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken cbracken approved these changes

+1 more reviewer

@mklim mklim mklim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. t: gradle "flutter build" and "flutter run" on Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jason-simmons @dnfield @bradyt @cbracken @mklim @zoechi @googlebot