Move flutter_assets to App.framework #26630

dnfield · 2019-01-16T07:24:39Z

This moves the flutter_assets folder to App.framework. The engine side is already set up to use this correctly, and has been for some time.

Updates xcode_backend.sh to write flutter_assets to App.framework folder
Removes need to copy that folder when embedding assets for Add2App
Changes upgradePbxProjWithFlutterAssets to remove references to flutter_assets and app.flx.
- Adds test for that method
- Makes that method more efficient rather than doing multiple iterations of the pbxproj lines. Even if we can't land this patch, we should land a fix for that.
Updates pbxproj.tmpl files to remove references to flutter_assets.

This will make our Add2App story take one less step for iOS. It will also improve our ability to support Carthage (we can just vend the frameworks and the assets are included).

Fixes #23839

Helps with #26099

dnfield · 2019-01-16T18:39:02Z

For reviewers - 1215156 is the meat of this change, the second commit is updating all the pbxproj files in our various samples/tests so we don't end up rewriting them every time.

dnfield · 2019-01-16T21:16:26Z

Helps with #24176

xster · 2019-01-16T21:29:25Z

packages/flutter_tools/lib/src/ios/mac.dart

+    final Match match = oldAssets.firstMatch(line);
+    if (match != null) {
+      if (printedStatuses.add(match.group(1)))
+        printStatus('Removing obsolete reference to ${match.group(1)} from ${project.hostAppBundleName}');


Where are you removing it? If someone flutter created before, have the flutter_assets 'folder' in pbxproj, what's going to remove it for them?

The continue statement on the next line skips adding it to the StringBuffer.

Think that'd be preferable as an else clause?

xster · 2019-01-16T21:30:43Z

LGTM

This reverts commit d8db70a.

* move flutter_assets to App.framework * remove flutter_assets references from all pbxproj files checked in

…r#26675) This reverts commit d8db70a.

1. Let flutter/flutter#26630 flutter_assets migrator run 2. Run `pod install` so flutter_assets is removed from the asset copy build phase 3. Migrate deprecated "English" to "en" language 4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724 5. Let Xcode 11 update build settings 6. Remove ARCHS, which was causing a compilation error

1. Let flutter/flutter#26630 flutter_assets migrator run 2. Run `pod install` so flutter_assets is removed from the asset copy build phase 3. Migrate deprecated "English" to "en" language 4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724 5. Let Xcode 11 update build settings 6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one) 7. Looks like this was last run with `use_frameworks!`? Let CocoaPods build as libraries instead of frameworks. 8. Remove ARCHS, which was causing a compilation error

1. Let flutter/flutter#26630 flutter_assets migrator run 2. Run `pod install` so flutter_assets is removed from the asset copy build phase 3. Migrate deprecated "English" to "en" language 4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724 5. Let Xcode 11 update build settings 6. Remove extraneous framework outputs flutter/flutter#20685