Actively reject UiKitView gestures. #25792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter/engine#7307 changes the engine side of embedded UIView to only reject gestures when the framework sends a `rejectGesture` message, so that gesture resolution can done after a touch sequence has ended (see PR description for flutter/engine#7307 for more details). This change makes the framework send a `rejectGesture` message to the engine when a UiKitView rejects a gesture. I'm planning to land this PR before the engine side change, so right now it swallows the exception thrown if there is no engine implementation for `rejectGesture` (which keeps us with the current behavior). After this change lands I'll land the engine PR, and then clean up the part that swallows the exception.
sbaranov
approved these changes
Dec 26, 2018
kangwang1988
added a commit
to XianyuTech/flutter
that referenced
this pull request
Dec 27, 2018
* flt_master: Actively reject UiKitView gestures. (flutter#25792) Roll engine e75fad7..9daf5c8 (3 commits) (flutter#25786) Roll engine d8c5ec0..e75fad7 (5 commits) (flutter#25757) Include cursor in textfield intrinsic width measurement (flutter#25055)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine#7307 changes the engine side of embedded UIView to only
reject gestures when the framework sends a
rejectGesturemessage, sothat gesture resolution can done after a touch sequence has ended (see
PR description for flutter/engine#7307 for more details).
This change makes the framework send a
rejectGesturemessage to theengine when a UiKitView rejects a gesture.
I'm planning to land this PR before the engine side change, so right now
it swallows the exception thrown if there is no engine implementation
for
rejectGesture(which keeps us with the current behavior). Afterthis change lands I'll land the engine PR, and then clean up the part
that swallows the exception.
#24076