Skip to content

Adds favicon to Dash/Zeal docset, adds OpenSearch metadata. #25178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 2 commits into from
Dec 11, 2018
Merged

Adds favicon to Dash/Zeal docset, adds OpenSearch metadata. #25178

gspencergoog merged 2 commits into from
Dec 11, 2018

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Dec 11, 2018 •
edited
Loading

This sets the favicon for the offline Dash/Zeal docs.

Also, sets up the OpenSearch Description metadata file so that people can create custom search shortcuts for the API docs site.

Fixes #6412

goderbauer
goderbauer approved these changes Dec 11, 2018
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoechi zoechi added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Dec 11, 2018
@gspencergoog gspencergoog merged commit 625a37b into flutter:master Dec 11, 2018
jonahwilliams pushed a commit that referenced this pull request Dec 11, 2018
Revert "Adds favicon to Dash/Zeal docset, adds OpenSearch metadata. (#…
70d917c 
…25178)"

This reverts commit 625a37b.
@gspencergoog gspencergoog deleted the dash_icon branch February 12, 2019 17:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs.flutter.io missing open search description (doesn't tab-search in chrome)

5 participants

@gspencergoog @goderbauer @tvolkert @zoechi @googlebot