[H] Support setting the elevation of disabled floating action buttons #24728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HansMuller This will also require a golden file update but I'll wait until the tree is open and I'm ready to land before rolling the goldens repo. |
Hixie
added a commit
to flutter/goldens
that referenced
this pull request
Dec 23, 2018
ba4c77b to
4d42e26
Compare
GaryQian
reviewed
Jan 3, 2019
Contributor
|
This is blocking another PR that wants to update goldens - would it be better to revert the goldens changes for this PR, or is this close to landing? |
dnfield
added a commit
to flutter/goldens
that referenced
this pull request
Jan 10, 2019
This reverts commit f948682.
Contributor
|
(I reverted the changes for this in goldens - they'll have to be added back when this is ready) |
427c7b9 to
aa90a1a
Compare
Hixie
added a commit
to flutter/goldens
that referenced
this pull request
Jan 14, 2019
aa90a1a to
ac3802d
Compare
Previously, a disabled floating action button always had zero elevation, which looks dumb. This also fixes the issue whereby highlightElevation was not honoured on floating action buttons. This also fixes an issue I found during testing whereby setState was being called during build when onHighlightChanged fired due to onPressed becoming null while a gesture is ongoing (which triggers an onTapCancel synchronously during build).
ac3802d to
7557716
Compare
Contributor
|
Related to #227 |
Contributor
Author
|
This is ready and awaiting review. |
HansMuller
approved these changes
Jan 15, 2019
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Sorry about the monumental review delay.
LGTM
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
…utter#24728) Previously, a disabled floating action button always had zero elevation, which looks dumb. This also fixes the issue whereby highlightElevation was not honoured on floating action buttons. This also fixes an issue I found during testing whereby setState was being called during build when onHighlightChanged fired due to onPressed becoming null while a gesture is ongoing (which triggers an onTapCancel synchronously during build).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a disabled floating action button always had zero
elevation, which looks dumb.
This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.
This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).