Reland Xcode backend refactor #23574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
reviewed
Oct 29, 2018
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Member
There was a problem hiding this comment.
I think every project should have this check plist and the legacy build xcsettings checked in to avoid git dirty builds in xcode 10
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
* Use Xcode build configurations to drive Flutter build mode * Proper check wrt local_engine, print error if profile mode misisng * Remove unused code, update tests, fix template problem, update warning * fix up warning * add explanatory dev comment * fix whitespace * missing words, change lambda arrow to function body * error indentation * Test early exits for xcode_backend.sh * only on macOS, use right test * Update error messages * case insensitive compare for build config * Update gallery podfile * update projects to add profile configuration * make compatible with flavors * add missing plist files
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
* Revert "Update templates (flutter#23698)" This reverts commit 5b0de6d. * Revert "Verify that date/number translations exist for all supported languages (flutter#23692)" This reverts commit 3449edf. * Revert "Reland Xcode backend refactor (flutter#23574)" This reverts commit 7270f28.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR had to be reverted (#23528) becuase it caused several device lab failures and failed to build the flutter_gallery.
The following updates have been made
Runner.xcodeprojprojects in examples/ and dev/ to add a "Profile" configuration to support running in profile mode (used in device lab tests/benchmarks). (aa3851d)Opening this as a new PR since the CI checks got messed up on the other reland PR.