Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

This is intended to be a stop-gap measure until we can refactor the flutter tool to fully support fuchsia.

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OverrideArtifacts({
@required this.parent,
this.frontendServer,
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

: assert(parent != null);

@jonahwilliams jonahwilliams merged commit c9ca7c4 into flutter:master Oct 16, 2018
@jonahwilliams jonahwilliams deleted the fuchsia_hot_reload branch October 16, 2018 21:27
zanderso pushed a commit that referenced this pull request Jan 13, 2021
* 51dd6aa [web] Enable the new rich paragraph implementation (flutter/engine#23162)

* 0f9fc3d Roll Skia from 7cf3addb1bd8 to 93c2d81f199a (1 revision) (flutter/engine#23614)

* a1e7424 [dart-runner] Avoid calling Destroy on nullptr (flutter/engine#23608)

* 846d958 Windows textures: Add placeholder flutter_texture_registrar.h (flutter/engine#23623)

* 55afc18 Roll Dart SDK from 7fcbd388b620 to ef8bf7f0a667 (5 revisions) (flutter/engine#23628)

* d2b8154 [canvaskit] apply invser scale on the left (flutter/engine#23550)

* be1a3c0 Roll Fuchsia Linux SDK from UB6RsTbdU... to FfWbbB4r8... (flutter/engine#23633)

* f743c89 Roll Skia from 93c2d81f199a to 9fd75e96d712 (29 revisions) (flutter/engine#23635)

* cf42dbe Roll wuffs to google/wuffs@c86add2 (flutter/engine#23607)

* f1278d0 Link SkShaper/SkParagraph into the engine by default (flutter/engine#23626)

* fb56b4b Android deeplink sends "path + query" instead of just path (flutter/engine#23561)

* 22bb891 Plumbing refactor to allow the usage of Dart_CreateIsolateInGroup (flutter/engine#23549)

* 20991a5 Add accessibility suport to Linux shell. (flutter/engine#19634)

* 145922b Roll Dart SDK from ef8bf7f0a667 to 636ff0ec97e0 (1 revision) (flutter/engine#23639)

* 176ae6e Roll Fuchsia Mac SDK from oll0Dgp9o... to JSzm8D59u... (flutter/engine#23641)

* d2320a8 Roll Dart SDK from 636ff0ec97e0 to d3d7b77e8165 (1 revision) (flutter/engine#23642)

* 8bdd099 Roll Skia from 9fd75e96d712 to 38ca513408d1 (1 revision) (flutter/engine#23643)

* cc572e1 Roll Skia from 38ca513408d1 to be2a8614c5d6 (2 revisions) (flutter/engine#23644)

* e9383a0 Roll Dart SDK from d3d7b77e8165 to 010633edc631 (1 revision) (flutter/engine#23645)

* 9d6ed8b Roll Fuchsia Linux SDK from FfWbbB4r8... to BUsKF6z4t... (flutter/engine#23646)

* 6d55dd4 Roll Dart SDK from 010633edc631 to 724d9e5e7d71 (1 revision) (flutter/engine#23647)

* 299f081 Roll Skia from be2a8614c5d6 to 0d7de6bc9ac3 (1 revision) (flutter/engine#23648)

* 0ec99cf Roll Fuchsia Mac SDK from JSzm8D59u... to BsUY1yjWh... (flutter/engine#23650)

* 859494f Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter/engine#23651)

* 648dae9 Roll Skia from 0d7de6bc9ac3 to 92969f265686 (7 revisions) (flutter/engine#23652)
cbracken pushed a commit that referenced this pull request Jan 14, 2021
* d7b25f9 [web] Reland: Enable the new rich paragraph implementation (flutter/engine#23659)

* 507a887 fix ax unique id flake (flutter/engine#23518)

* e5a4c7c Roll Fuchsia Linux SDK from BUsKF6z4t... to a7ezEWPM5... (flutter/engine#23668)

* 7d1e4e3 Roll Skia from 0e4a29af9db2 to af9b58e287b5 (10 revisions) (flutter/engine#23670)

* 635f64a Roll Skia from af9b58e287b5 to f435ada424df (1 revision) (flutter/engine#23671)

* 6957611 Roll Fuchsia Mac SDK from BsUY1yjWh... to BoBy7Eobf... (flutter/engine#23672)

* 37131f1 Use non-deprecated SkImageFilter factory functions (flutter/engine#23649)

* 38f08ff Roll Fuchsia Linux SDK from a7ezEWPM5... to erwxDS3kf... (flutter/engine#23676)

* a56183c Roll Skia from f435ada424df to 8f78d5528438 (7 revisions) (flutter/engine#23680)

* 9d75996 Revert "[web] Enable the new rich paragraph implementation (#23162)" (flutter/engine#23687)

* b030bc8 Roll Dart SDK from 724d9e5e7d71 to 3629a798353d (1 revision) (flutter/engine#23681)

* a8a7534 Support Mice in iPadOS 13.4+ (flutter/engine#23636)

* 3f691f0 [web] Fix semantic node order for webkit (flutter/engine#23601)

* 70d08c6 Roll Skia from 8f78d5528438 to 890b2b406a60 (9 revisions) (flutter/engine#23692)

* 5459565 Roll Fuchsia Mac SDK from BoBy7Eobf... to DVYrV15dq... (flutter/engine#23693)

* 3fd4c63 [web] Fix letter spacing for rich paragraphs (flutter/engine#23683)

* effb529 Added missing export for the flutter engine group. (flutter/engine#23689)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants