Gradle plugin support for adding flutter as subproject to another Android app #22707
Conversation
… assets. This deflakes old behavior that suffered from nondeterminism because of reliance on the order of siblings in the dependency graph. As a side effect, this also undoes the hack introduced in #14085 that increased build time by churning the output tree. This hack is no longer necessary since --preview-dart-2 flag is gone.
|
This should also fix #18101. |
|
I confirmed that the relevant change is still in the tip-of-tree flutter/flutter. |
|
I can also confirm that I have the current master and still running into the issue #19818 |
|
@passsy @filipproch Are you sure you're seeing the same exact issue? Are you're following the same exact steps outlined in #19818, adding fabric.io, etc? |
|
@sbaranov the error message is the same, the difference is whether I have apply fabric plugin or not. If I comment out the apply, the app launches. I can try to collect more info. |
|
Yeah, we'd need a small example that reproduces the problem for us since we don't know what other things might still be affecting this. For example, are you seeing this problem if you follow the Add-to-App tutorial from scratch, and then only add fabric.io plugin? |
|
Still got #19818 problems. And flutter-doctor shows everything is fine. The problem of my project is missing of flutter_assets. What else can I provide to help this issue? |
|
@jason-simmons I have the latest master branch and the issue still exists. When I create a whole new Android project as host app, it works, But my old project not. I explored the apk build by my old project, and flutter_assets folder is not included. I cannot figure out why for now. |
|
Issue still exists in latest master |
This fixes #19818 by ensuring that VM snapshot is copied from artifacts before gradle merges assets.