Change file paths to URIs to fix "Could not run configuration in engine" on Windows #22507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne" on Windows Plus unskip test that was failing due to this. Fixes #21348.
Contributor
Author
|
There's still a failing test that was marked with the same issue, however it seems to be hanging waiting for a breakpoint hit so I'll investigate that separately. This test was definitely failing with the message from #21348 prior to this change. |
Contributor
Author
|
The other tests were failing due to sending FS path instead of URIs for breakpoints. I've opened #22510 for that. |
This was referenced Oct 1, 2018
jason-simmons
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus unskip test that was failing due to this.
Fixes #21348.