Default clipBehavior of ClipRect to hardEdge. #21703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
GaryQian
added a commit
to flutter/goldens
that referenced
this pull request
Sep 11, 2018
9da77d3 to
4688f9d
Compare
tvolkert
approved these changes
Sep 11, 2018
liyuqian
approved these changes
Sep 11, 2018
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
Contributor
|
LGTM, but please make sure to add more documentation soon. Thanks! |
Member
|
FYI: My golden files update for an engine roll overwrite your golden update for this PR, see flutter/goldens#17. |
GaryQian
added a commit
to flutter/goldens
that referenced
this pull request
Sep 12, 2018
Contributor
|
FYI: you can also |
e31d62b to
fbbb5cf
Compare
Contributor
|
This seems to have had no effect on the regression. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using antiAlias in ClipRect, which is no longer the default, is now slow since flutter/engine#6199 enables AA.
Background:
Previously, the engine did not properly pass the AA flag on ClipRect.clipBehavior. flutter/engine#6199 fixes this and enables AA. However, default AA on clipRects has caused severe regressions in benchmark performance.
To maintain expected performance, we should now default the clipBehavior to hardEdge to disable default AA. This is consistent with any flutter projects that did not previously explicitly set the clipBehavior and should not change app appearance.
Migration:
For the most part, there should be minimal if any need to migrate code, but I will be glad to assist anyone to achieve the expected clipping behavior.
Summary:
clipBehavior is now properly respected instead of always hardEdge. Any expectation of anti-aliasing should be re-evaluated in regards to performance.
#21702