Roll engine to 9b297b3b51228... and Update goldens for flutter/engine#6184 #21519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
reviewed
Sep 6, 2018
Contributor
liyuqian
left a comment
There was a problem hiding this comment.
You might need to also roll the engine version to include your engine commit to pass the test.
Contributor
|
The tests are failing because our Chrome bots haven't finished building the engine version f02fc8c yet. You'll have to wait all build jobs to finish in https://build.chromium.org/p/client.flutter/console for that version. |
Contributor
Author
|
#21509 required to pass all tests for Dart SDK roll, and windows build failing for flutter/engine@58a1894. Rolling engine to one commit before the clang update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git log 5f61056..9b297b3 --no-merges --oneline
9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (#6190)
e70d0e1 Always serialize fonts during skp capturing (#6160)
bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (#6187)
30c8da8 Pull $flutter_root:config into shell/engine/version:version (#6186)
a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (#6185)
058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (#6184)