Fixed missing implementations of toString() in two tests #21509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
Sep 6, 2018
Member
aam
left a comment
There was a problem hiding this comment.
cc @yjbanov @matthew-carroll original authors of _TextStyleProxy and _FakeTicker classes
yjbanov
approved these changes
Sep 6, 2018
Contributor
|
I'm confused by this change. What is the purpose here? |
Contributor
|
oh, I see. It's because the interface changes the API compared to Object. |
Member
Right, it went unnoticed until recently dart frontend started to flag this kind of errors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.