Skip to content

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Aug 17, 2018

This reverts commit 8de0e15 as #20751 and #20836 has landed.

Everything in flutter_gallery looks good to me.

@liyuqian liyuqian changed the title Set the default clip to Clip.none again. [wip] Set the default clip to Clip.none again. Aug 17, 2018
This reverts commit 8de0e15 and
updates the goldens versoin.

This requires flutter#20751 to
land first.
@liyuqian liyuqian changed the title [wip] Set the default clip to Clip.none again. Set the default clip to Clip.none again. Aug 22, 2018
liyuqian added a commit to flutter/goldens that referenced this pull request Aug 22, 2018
@liyuqian
Copy link
Contributor Author

@jonahwilliams Everything looks good to me in flutter gallery. Can you please take a look at this PR?

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit ce8ba6e into flutter:master Aug 24, 2018
@liyuqian liyuqian deleted the noclip branch August 27, 2018 23:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants