Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Jul 5, 2018

This will be reverted after the tests have run. There's a failure in the device lab tests but we're not getting the output because the completion is failing (because the future is already completed). This just prints the exception that's occurring and also the other locations that are completing (so we know why it's trying to complete twice).

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanTup
Copy link
Contributor Author

DanTup commented Jul 5, 2018

Landing on red to try and get a better error message for the failures. This change will be reverted after the next run.

@DanTup DanTup merged commit edc1647 into flutter:master Jul 5, 2018
DanTup added a commit that referenced this pull request Jul 5, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants