Skip to content

[CP-beta] Remove EnableTransparentWindowBackground because it did nothing important and because Windows 10 does not support DWMWA_SYSTEMBACKDROP_TYPE (#187848)#188186

Merged
auto-submit[bot] merged 3 commits into
flutter:flutter-3.46-candidate.0from
LongCatIsLooong:windows_host_engine_test
Jun 25, 2026
Merged

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is for fixing a flaky test so no changlog entries needed.

Hopefully this resolves #188182

I doubt we can use the auto-CP bot because the initial beta has not been released.

Original PR: #187848

Pre-launch Checklist

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@LongCatIsLooong LongCatIsLooong requested a review from a team as a code owner June 18, 2026 19:14
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026
@flutter-dashboard

flutter-dashboard Bot commented Jun 18, 2026

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@fluttergithubbot

fluttergithubbot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

An existing Git SHA, 90b4e63abeb5fcc93b9cfd7770e258933956989e, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

@github-actions github-actions Bot added engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop team-windows Owned by the Windows platform team labels Jun 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the EnableTransparentWindowBackground helper function and its invocation from the HostWindow::WndProc method in the Windows platform shell. I have no feedback to provide.

loic-sharma
loic-sharma approved these changes Jun 18, 2026
View reviewed changes

@loic-sharma loic-sharma left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2026
@auto-submit

This comment was marked as outdated.

Sign in to view
@mattkae @loic-sharma
Remove EnableTransparentWindowBackground because it did nothing impor…
672dc44 
…tant and because Windows 10 does not support DWMWA_SYSTEMBACKDROP_TYPE (flutter#187848)

This pull request makes multi-window functional on Windows 10 and
removes an unnecessary call during window setup.

## What's new?
- Removes call to `EnableTransparentWindowBackground` on `HostWindow`
create. In fact, this does not work at all 🎉 Transparency on popups
was not implemented with the current implementation. We should do
something more complex to make it work, but it has clearly been broken
for a while now

fixes flutter#186522

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
@loic-sharma loic-sharma force-pushed the windows_host_engine_test branch from 90b4e63 to 672dc44 Compare June 18, 2026 20:34
@loic-sharma

loic-sharma commented Jun 18, 2026

Copy link
Copy Markdown
Member

@LongCatIsLooong This was hitting some weird CI failures (example). I rebased the PR to get a fresh CI run.

@loic-sharma loic-sharma mentioned this pull request Jun 18, 2026
Merged
10 tasks
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026
@loic-sharma loic-sharma added the CICD Run CI/CD label Jun 18, 2026
@flutter-dashboard

flutter-dashboard Bot commented Jun 18, 2026

Copy link
Copy Markdown

CI had a failure that stopped further tests from running. We need to investigate to determine the root cause.

SHA at time of execution: 672dc44.

Possible causes:

  • Configuration Changes: The .ci.yaml file might have been modified between the creation of this pull request and the start of this test run. This can lead to ci yaml validation errors.
  • Infrastructure Issues: Problems with the CI environment itself (e.g., quota) could have caused the failure.

A blank commit, or merging to head, will be required to resume running CI for this PR.

Error Details:

GitHub Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. For more on scraping GitHub and how it may affect your rights, please review our Terms of Service (https://docs.github.com/en/site-policy/github-terms/github-terms-of-service) If you reach out to GitHub Support for help, please include the request ID C052:9AD8F:A5B40EA:263BC89D:6A3465EC.

Stack trace:

#0      GitHub.handleStatusCode (package:github/src/common/github.dart:486:5)
#1      GitHub.request (package:github/src/common/github.dart:422:7)
<asynchronous suspension>
#2      GitHub.requestJson (package:github/src/common/github.dart:323:22)
<asynchronous suspension>
#3      RetryOptions.retry (package:retry/retry.dart:131:16)
<asynchronous suspension>
#4      LuciBuildService._scheduleTryBuilds (package:cocoon_service/src/service/luci_build_service.dart:307:26)
<asynchronous suspension>
#5      Scheduler._runCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1476:9)
<asynchronous suspension>
#6      Scheduler.proceedToCiTestingStage (package:cocoon_service/src/service/scheduler.dart:1527:7)
<asynchronous suspension>
#7      Scheduler._closeSuccessfulEngineBuildStage (package:cocoon_service/src/service/scheduler.dart:1341:5)
<asynchronous suspension>
#8      Scheduler.processCheckRunCompleted (package:cocoon_service/src/service/scheduler.dart:1273:11)
<asynchronous suspension>
#9      PresubmitLuciSubscription.post (package:cocoon_service/src/request_handlers/presubmit_luci_subscription.dart:176:9)
<asynchronous suspension>
#10     RequestHandler.service (package:cocoon_service/src/request_handling/request_handler.dart:42:20)
<asynchronous suspension>
#11     SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:139:5)
<asynchronous suspension>
#12     createServer.<anonymous closure> (package:cocoon_service/server.dart:448:7)
<asynchronous suspension>
#13     main.<anonymous closure>.<anonymous closure> (file:///app/app_dart/bin/gae_server.dart:187:9)
<asynchronous suspension>

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026
@LongCatIsLooong LongCatIsLooong added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 18, 2026
@auto-submit

auto-submit Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/188186, Failed to merge flutter/flutter/188186 with Pull request flutter/flutter/188186 could not be merged: Required status check "ci.yaml validation" is expected..

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 18, 2026
@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
@auto-submit

auto-submit Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188186, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
@auto-submit

auto-submit Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/188186, because - The status or check suite Windows windows_host_engine_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 19, 2026
@LongCatIsLooong

LongCatIsLooong commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Windows windows_host_engine_test is consistently failing for this CP. The beta release is currently blocked by #188075 so this may not be high priority.

@loic-sharma

loic-sharma commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I think the test failures are something else:

See also:

I'll cherry pick the revert PR for the Windows stylus buttons. That will need to land before this cherry pick.

EDIT: Here's the cherry pick for the revert PR: #188341

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 23, 2026
@LongCatIsLooong LongCatIsLooong mentioned this pull request Jun 23, 2026
Merged
@LongCatIsLooong LongCatIsLooong added CICD Run CI/CD cp: review Cherry-picks in the review queue labels Jun 23, 2026
@walley892 walley892 added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2026
@LongCatIsLooong LongCatIsLooong added CICD Run CI/CD and removed CICD Run CI/CD labels Jun 25, 2026
@auto-submit auto-submit Bot merged commit 9281300 into flutter:flutter-3.46-candidate.0 Jun 25, 2026
180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes
@walley892 walley892 walley892 approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD cp: review Cherry-picks in the review queue engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically team-windows Owned by the Windows platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LongCatIsLooong @fluttergithubbot @loic-sharma @walley892 @mattkae